Skip to content

Commit 9ca6322

Browse files
committed
Remove shared reconnectms, improve self.started
We still need to set it in batchShutdown()
1 parent 957fe1d commit 9ca6322

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

mininet/node.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1273,20 +1273,13 @@ def connected( self ):
12731273
class OVSBatch( OVSSwitch ):
12741274
"Experiment: batch startup of OVS switches"
12751275

1276-
reconnectms = 1000 # shared for all switches
1277-
12781276
# This should be ~ int( quietRun( 'getconf ARG_MAX' ) ),
12791277
# but the real limit seems to be much lower
12801278
argmax = 128000
12811279

12821280
def __init__( self, *args, **kwargs ):
12831281
self.commands = []
12841282
self.started = False
1285-
# Use global rather than local reconnectms
1286-
reconnectms = kwargs.pop( 'reconnectms', 1000 )
1287-
self.__class__.reconnectms = max( reconnectms,
1288-
self.__class__.reconnectms )
1289-
kwargs.update( reconnectms=None )
12901283
super( OVSBatch, self ).__init__( *args, **kwargs )
12911284

12921285
@classmethod
@@ -1316,6 +1309,14 @@ def vsctl( self, *args, **kwargs ):
13161309
cmd = ' '.join( str( arg ).strip() for arg in args )
13171310
self.commands.append( cmd )
13181311

1312+
def start( self, *args, **kwargs ):
1313+
super( OVSBatch, self ).start( *args, **kwargs )
1314+
self.started = True
1315+
1316+
def stop( self, *args, **kwargs ):
1317+
super( OVSBatch, self ).stop( *args, **kwargs )
1318+
self.started = False
1319+
13191320
def cleanup( self):
13201321
"Don't bother to clean up"
13211322
return

0 commit comments

Comments
 (0)