fix(image): use default scale factor if passed value is not positive

DudaGod · DudaGod · commit ad55ed0b9e0d · 2018-01-15T01:59:10.000+03:00
diff --git a/lib/image/index.js b/lib/image/index.js
@@ -58,7 +58,9 @@ module.exports = class Image {
         return this;
     }
 
-    _scale(area, scaleFactor = 1) {
+    _scale(area, scaleFactor) {
+        scaleFactor = scaleFactor || 1;
+
         return {
             left: area.left * scaleFactor,
             top: area.top * scaleFactor,
diff --git a/test/lib/image/index.js b/test/lib/image/index.js
@@ -54,6 +54,13 @@ describe('Image', () => {
                 .then(() => assert.calledWith(SafeRect.create, scaledRect));
         });
 
+        it('should use default scale factor (one) if the passed value is not positive', () => {
+            const rect = {left: 1, top: 2, width: 3, height: 4};
+
+            return image.crop(rect, {scaleFactor: null})
+                .then(() => assert.calledWith(SafeRect.create, rect));
+        });
+
         it('should crop an image', () => {
             SafeRect.create.returns({left: 1, top: 2, width: 3, height: 4});
 
