Skip to content

Commit c41c14c

Browse files
aeaton-overleafCopybot
authored andcommitted
Remove deprecated grunt code (#9506)
GitOrigin-RevId: 2b19d73c593545aaa9f6eb88143d08c5df39a1be
1 parent 7ce229b commit c41c14c

8 files changed

Lines changed: 6 additions & 176 deletions

File tree

server-ce/bin/grunt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,25 +2,30 @@
22
# Thin wrapper on old grunt tasks to ease migrating.
33

44
set -e
5+
set -x
56
TASK="$1"
67
shift 1
78

89
cd /overleaf/services/web
910

1011
case "$TASK" in
1112
user:create-admin)
13+
echo "The grunt command is deprecated, run the create-user script using node instead"
1214
node modules/server-ce-scripts/scripts/create-user --admin "$@"
1315
;;
1416

1517
user:delete)
18+
echo "The grunt command is deprecated, run the delete-user script using node instead"
1619
node modules/server-ce-scripts/scripts/delete-user "$@"
1720
;;
1821

1922
check:mongo)
23+
echo "The grunt command is deprecated, run the check-mongodb script using node instead"
2024
node modules/server-ce-scripts/scripts/check-mongodb
2125
;;
2226

2327
check:redis)
28+
echo "The grunt command is deprecated, run the check-redis script using node instead"
2429
node modules/server-ce-scripts/scripts/check-redis
2530
;;
2631

services/clsi/test/acceptance/scripts/full-test.sh

Lines changed: 0 additions & 23 deletions
This file was deleted.

services/clsi/test/acceptance/scripts/settings.test.js

Lines changed: 0 additions & 49 deletions
This file was deleted.

services/docstore/test/acceptance/scripts/full-test.sh

Lines changed: 0 additions & 23 deletions
This file was deleted.

services/real-time/test/acceptance/scripts/full-test.sh

Lines changed: 0 additions & 23 deletions
This file was deleted.

services/web/README.md

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,6 @@ a lot of logic around creating and editing projects, and account management.
1010
The rest of the Overleaf stack, along with information about contributing can be found in the
1111
[overleaf/overleaf](https://github.com/overleaf/overleaf) repository.
1212

13-
Build process
14-
----------------
15-
16-
overleaf/web uses [Grunt](http://gruntjs.com/) to build its front-end related assets.
17-
18-
Image processing tasks are commented out in the gruntfile and the needed packages aren't presently in the project's `package.json`. If the images need to be processed again (minified and sprited), start by fetching the packages (`npm install grunt-contrib-imagemin grunt-sprity`), then *decomment* the tasks in `Gruntfile.coffee`. After this, the tasks can be called (explicitly, via `grunt imagemin` and `grunt sprity`).
19-
20-
New Docker-based build process
21-
------------------------------
22-
23-
Note that the Grunt workflow from above should still work, but we are transitioning to a
24-
Docker based testing workflow, which is documented below:
25-
2613
### Running the app
2714

2815
The app runs natively using npm and Node on the local system:
@@ -32,8 +19,6 @@ $ npm install
3219
$ npm run start
3320
```
3421

35-
*Ideally the app would run in Docker like the tests below, but with host networking not supported in OS X, we need to run it natively until all services are Dockerised.*
36-
3722
### Running Tests
3823

3924
To run all tests run:

services/web/config/settings.defaults.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -486,9 +486,7 @@ module.exports = {
486486
? process.env.PRECOMPILE_PUG_TEMPLATES_AT_BOOT_TIME === 'true'
487487
: process.env.NODE_ENV === 'production',
488488

489-
// Should javascript assets be served minified or not. Note that you will
490-
// need to run `grunt compile:minify` within the web-sharelatex directory
491-
// to generate these.
489+
// Should javascript assets be served minified or not.
492490
useMinifiedJs: process.env.MINIFIED_JS === 'true' || false,
493491

494492
// Should static assets be sent with a header to tell the browser to cache

services/web/test/acceptance/scripts/full-test.sh

Lines changed: 0 additions & 40 deletions
This file was deleted.

0 commit comments

Comments
 (0)