#39 Support to multiple command source directories#41
Merged
erikaheidi merged 1 commit intomainfrom May 31, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support to multiple command source directories. With this change, it is possible to pass an array of paths instead of a single string to the config, and the autoloader will pick up command namespaces from all configured paths.
Strings are still allowed as we added a check to make sure we transform them into arrays before registering the command registry service. So no backwards compatibility issues.
The motivation behind this update is to allow commands to be shared and reused more easily, which in turn will facilitate extending Minicli.