fix: conditionally show items in insert figure toolbar#1477
Open
MonsterDruide1 wants to merge 1 commit intooverleaf:mainfrom
Open
fix: conditionally show items in insert figure toolbar#1477MonsterDruide1 wants to merge 1 commit intooverleaf:mainfrom
insert figure toolbar#1477MonsterDruide1 wants to merge 1 commit intooverleaf:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the options for inserting an image from another project or by downloading an external URL, if this feature has been determined to be disabled by the lack of configuration.
The conditions have been copied from insert-figure-dropdown.tsx
Related issues / Pull Requests
In the community issue,
linkedUrlProxycannot be configured. Therefore, trying to download any image from an external URL fails through trying to readlinkedUrlProxy.urlwithlinkedUrlProxy=undefinedin UrlHelper.mjs. However, this window and configuration should not even be accessible in this case, which is fixed in this PR.Contributor Agreement
I am hereby signing off all my copyrights and declare this patch to be in the public domain (CC0). I don't plan on signing your contribution agreement, but please fix your code anyways.