Support DescribeTableSubtree in ginkgo outline#1655
Merged
onsi merged 1 commit intoonsi:masterfrom May 8, 2026
Merged
Conversation
Owner
|
hey sorry for the radio silence - this is fantastic! thanks for taking the time to implement it and test it so thoroughly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1556
ginkgo outlinedid not recognizeDescribeTableSubtreeand its variants(
FDescribeTableSubtree,PDescribeTableSubtree,XDescribeTableSubtree),causing the outline to miss the node entirely and flatten its children.
This PR:
Adds all
DescribeTableSubtreevariants to the node recognition inginkgoNodeFromCallExprAdds
expandSubtreelogic to restructure the tree so eachEntryunder aDescribeTableSubtreegets a copy of the subtree's spec nodes as children,mirroring runtime behavior
Adds a dedicated test fixture covering: single/multi-spec body, focused,
pending, and X-pending variants
Updates existing fixtures (focused, pending, nodot, alias) to include
DescribeTableSubtreevariantsTest plan
go vet ./...passesginkgo -r -p— all 17 suites pass, 0 failuresdescribe_table_subtree_test.gowith CSV + JSONfocused_test.go,pending_test.go,nodot_test.go,alias_test.go