Conversation
…ssLog Controller API The previous check was not correct, as it discarded topics that have diskless.enable=true but are not migrated yet. The same type of check is already done for each partition, but checking instead that the partition does not have disklessStartOffset already set.
86d9902 to
34eedd6
Compare
jeqo
approved these changes
Mar 20, 2026
AnatolyPopov
pushed a commit
that referenced
this pull request
Mar 23, 2026
…ssLog Controller API (#547) The previous check was not correct, as it discarded topics that have diskless.enable=true but are not migrated yet. The same type of check is already done for each partition, but checking instead that the partition does not have disklessStartOffset already set. (cherry picked from commit 501b2c0)
jeqo
pushed a commit
that referenced
this pull request
Mar 26, 2026
…ssLog Controller API (#547) The previous check was not correct, as it discarded topics that have diskless.enable=true but are not migrated yet. The same type of check is already done for each partition, but checking instead that the partition does not have disklessStartOffset already set.
jeqo
pushed a commit
that referenced
this pull request
Mar 26, 2026
…ssLog Controller API (#547) The previous check was not correct, as it discarded topics that have diskless.enable=true but are not migrated yet. The same type of check is already done for each partition, but checking instead that the partition does not have disklessStartOffset already set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous check was not correct, as it discarded topics that have diskless.enable=true but are not migrated yet.
The same type of check is already done for each partition, but checking instead that the partition does not have disklessStartOffset already set.