fix(inkless:metrics): Fix double-counting of diskless topic and partition metrics#552
Merged
giuseppelillo merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes controller metrics drift where diskless topic/partition metrics were double-counted when topic creation and diskless config updates occurred in the same metadata batch, ensuring diskless counts remain consistent with global counts over time.
Changes:
- Use
prevImage.configs()(instead ofnewImage.configs()) when classifying diskless status duringTopicDeltaprocessing to avoid double-counting. - Add regression tests covering diskless topic creation, deletion, and combined partition+config changes in a single delta batch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsPublisher.java |
Adjusts diskless classification during topic delta handling to prevent double increments when config deltas are also present. |
metadata/src/test/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsPublisherTest.java |
Adds targeted regression tests to validate diskless metrics correctness across delta scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tion metrics When a diskless topic was created, both the TopicDelta and ConfigDelta fired in the same metadata batch, causing disklessTopicCount and disklessPartitionCount to be incremented twice. Over time this caused DisklessTopicCount to drift above GlobalTopicCount. The fix uses prevImage.configs() instead of newImage.configs() when processing TopicDeltas, so that all diskless config transitions are handled exclusively by the config change loop. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cd0b9ab to
80f29c4
Compare
giuseppelillo
approved these changes
Mar 27, 2026
jeqo
added a commit
that referenced
this pull request
Mar 30, 2026
…tion metrics (#552) When a diskless topic was created, both the TopicDelta and ConfigDelta fired in the same metadata batch, causing disklessTopicCount and disklessPartitionCount to be incremented twice. Over time this caused DisklessTopicCount to drift above GlobalTopicCount. The fix uses prevImage.configs() instead of newImage.configs() when processing TopicDeltas, so that all diskless config transitions are handled exclusively by the config change loop. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
jeqo
added a commit
that referenced
this pull request
Mar 30, 2026
…tion metrics (#552) When a diskless topic was created, both the TopicDelta and ConfigDelta fired in the same metadata batch, causing disklessTopicCount and disklessPartitionCount to be incremented twice. Over time this caused DisklessTopicCount to drift above GlobalTopicCount. The fix uses prevImage.configs() instead of newImage.configs() when processing TopicDeltas, so that all diskless config transitions are handled exclusively by the config change loop. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a diskless topic was created, both the TopicDelta and ConfigDelta fired in the same metadata batch, causing disklessTopicCount and disklessPartitionCount to be incremented twice. Over time this caused DisklessTopicCount to drift above GlobalTopicCount.
The fix uses prevImage.configs() instead of newImage.configs() when processing TopicDeltas, so that all diskless config transitions are handled exclusively by the config change loop.