fix(inkless:migration): bypass diskless/remote-storage mutual exclusion for classic-to-diskless migration#555
Merged
viktorsomogyi merged 1 commit intomainfrom Mar 30, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts LogConfig validation to allow classic (tiered-storage) topics to enable diskless.enable=true during migration when diskless.allow.from.classic.enable is enabled, bypassing the diskless/remote mutual-exclusion check under specific conditions.
Changes:
- Add a conditional bypass for
diskless.enablevsremote.storage.enablemutual exclusion during classic-to-diskless migration. - Update unit tests to cover the intended migration scenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java | Adds migration-specific bypass for diskless/remote mutual exclusion validation. |
| core/src/test/scala/unit/kafka/log/LogConfigTest.scala | Updates/extends validation tests for disklessAllowFromClassic update behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…on for classic-to-diskless migration When diskless.allow.from.classic.enable is true and a topic is being migrated from classic (remote.storage.enable=true) to diskless, skip the mutual exclusion validation that prevents both configs from being set simultaneously. The bypass only triggers when all conditions are met: - diskless.allow.from.classic.enable is true (broker config) - diskless.enable is being explicitly set to true (request) - remote.storage.enable was previously set to true (existing topic config) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e08de83 to
3440b23
Compare
viktorsomogyi
approved these changes
Mar 30, 2026
jeqo
added a commit
that referenced
this pull request
Mar 30, 2026
…on for classic-to-diskless migration (#555) When diskless.allow.from.classic.enable is true and a topic is being migrated from classic (remote.storage.enable=true) to diskless, skip the mutual exclusion validation that prevents both configs from being set simultaneously. The bypass only triggers when all conditions are met: - diskless.allow.from.classic.enable is true (broker config) - diskless.enable is being explicitly set to true (request) - remote.storage.enable was previously set to true (existing topic config)
jeqo
added a commit
that referenced
this pull request
Mar 30, 2026
…on for classic-to-diskless migration (#555) When diskless.allow.from.classic.enable is true and a topic is being migrated from classic (remote.storage.enable=true) to diskless, skip the mutual exclusion validation that prevents both configs from being set simultaneously. The bypass only triggers when all conditions are met: - diskless.allow.from.classic.enable is true (broker config) - diskless.enable is being explicitly set to true (request) - remote.storage.enable was previously set to true (existing topic config)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When diskless.allow.from.classic.enable is true and a topic is being migrated from classic (remote.storage.enable=true) to diskless, skip the mutual exclusion validation that prevents both configs from being set simultaneously.
The bypass only triggers when all conditions are met: