Skip to content

feat(inkless): POD-2386 Allow remote.storage.enabled when diskless is enabled#556

Merged
viktorsomogyi merged 1 commit intomainfrom
svv/ts-unification-configs
Apr 8, 2026
Merged

feat(inkless): POD-2386 Allow remote.storage.enabled when diskless is enabled#556
viktorsomogyi merged 1 commit intomainfrom
svv/ts-unification-configs

Conversation

@viktorsomogyi
Copy link
Copy Markdown
Contributor

@viktorsomogyi viktorsomogyi commented Mar 30, 2026 •
edited
Loading

Adds the diskless.remote.storage.consolidation.enable config. When it is enabled, it will

  • allow setting diskless.enable and remote.storage.enable on new topics
  • allow setting remote.storage.enable on existing diskless topics (where diskless.enable is enabled)
    Setting remote.storag.enable on a diskless topic will be the intended way to start the consolidation of WAL segments into tiered topics.

@viktorsomogyi viktorsomogyi changed the title feat(inkless): Add TS Consolidation configs feat(inkless): Allow remote.storage.enabled when diskless too is enabled Mar 30, 2026
@viktorsomogyi viktorsomogyi marked this pull request as ready for review March 30, 2026 13:29
@viktorsomogyi viktorsomogyi changed the title feat(inkless): Allow remote.storage.enabled when diskless too is enabled feat(inkless): Allow remote.storage.enabled when diskless is enabled Mar 30, 2026
@viktorsomogyi viktorsomogyi force-pushed the svv/ts-unification-configs branch from 506e6e1 to a699d79 Compare March 31, 2026 09:36
jeqo
jeqo reviewed Mar 31, 2026
View reviewed changes
Comment thread storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java Outdated
Comment thread core/src/test/scala/unit/kafka/log/LogConfigTest.scala Outdated
Comment thread storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java Outdated
Comment thread server-common/src/main/java/org/apache/kafka/server/config/ServerConfigs.java
Comment thread core/src/main/scala/kafka/server/KafkaConfig.scala
Comment thread storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java Outdated
@viktorsomogyi viktorsomogyi marked this pull request as draft March 31, 2026 14:37
@jeqo jeqo mentioned this pull request Apr 1, 2026
Merged
@viktorsomogyi viktorsomogyi force-pushed the svv/ts-unification-configs branch from a699d79 to cbb9eca Compare April 1, 2026 13:52
@viktorsomogyi viktorsomogyi marked this pull request as ready for review April 1, 2026 13:53
@viktorsomogyi viktorsomogyi force-pushed the svv/ts-unification-configs branch 3 times, most recently from 5786342 to 12a8902 Compare April 1, 2026 14:19
jeqo
jeqo requested changes Apr 1, 2026
View reviewed changes
Comment thread core/src/test/scala/unit/kafka/log/LogConfigTest.scala Outdated
Comment thread storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java Outdated
jeqo
jeqo reviewed Apr 1, 2026
View reviewed changes
Comment thread core/src/main/scala/kafka/server/KafkaConfig.scala
@viktorsomogyi viktorsomogyi requested a review from jeqo April 2, 2026 07:59
jeqo
jeqo reviewed Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a few more suggestions. Let's also ensure CI is passing.

Comment thread core/src/test/scala/unit/kafka/log/LogConfigTest.scala Outdated
Comment thread core/src/test/scala/unit/kafka/log/LogConfigTest.scala Outdated
Comment thread storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
Comment thread core/src/test/scala/unit/kafka/log/LogConfigTest.scala Outdated
Comment thread storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
@viktorsomogyi viktorsomogyi changed the title feat(inkless): Allow remote.storage.enabled when diskless is enabled feat(inkless): POD-2386 Allow remote.storage.enabled when diskless is enabled Apr 2, 2026
viktorsomogyi
viktorsomogyi commented Apr 2, 2026
View reviewed changes
Comment thread core/src/test/scala/unit/kafka/log/LogConfigTest.scala Outdated
jeqo
jeqo reviewed Apr 2, 2026
View reviewed changes
Comment thread storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java Outdated
jeqo
jeqo reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A last round of suggestions to make the conditions on LogConfigHelper more explicit. Apart from this it looks good to me.

Comment thread storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java Outdated
Comment thread storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
jeqo
jeqo reviewed Apr 7, 2026
View reviewed changes
Comment thread storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java Outdated
jeqo
jeqo reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to publish this one 😅 should be the last one

Comment thread core/src/test/scala/unit/kafka/log/LogConfigTest.scala Outdated
jeqo
jeqo previously approved these changes Apr 7, 2026
View reviewed changes
jeqo
jeqo approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @viktorsomogyi !

@viktorsomogyi viktorsomogyi force-pushed the svv/ts-unification-configs branch from 3322431 to 0c55251 Compare April 8, 2026 08:14
giuseppelillo
giuseppelillo approved these changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@giuseppelillo giuseppelillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@viktorsomogyi viktorsomogyi force-pushed the svv/ts-unification-configs branch from 0c55251 to b6f36d2 Compare April 8, 2026 10:16
@viktorsomogyi viktorsomogyi merged commit 0986482 into main Apr 8, 2026
1 check passed
@viktorsomogyi viktorsomogyi deleted the svv/ts-unification-configs branch April 8, 2026 10:18
jeqo pushed a commit that referenced this pull request Apr 14, 2026
@viktorsomogyi @jeqo
feat(inkless): Add TS Consolidation configs (#556)
36aaee4 
POD-2386
jeqo pushed a commit that referenced this pull request Apr 14, 2026
@viktorsomogyi @jeqo
feat(inkless): Add TS Consolidation configs (#556)
7c74f6a 
POD-2386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeqo jeqo jeqo approved these changes

@giuseppelillo giuseppelillo giuseppelillo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@viktorsomogyi @jeqo @giuseppelillo