feat(inkless:test): implement system test for classic to diskless migration#581
Draft
giuseppelillo wants to merge 2 commits intomainfrom
Draft
feat(inkless:test): implement system test for classic to diskless migration#581giuseppelillo wants to merge 2 commits intomainfrom
giuseppelillo wants to merge 2 commits intomainfrom
Conversation
giuseppelillo
commented
Apr 27, 2026
Comment on lines
+298
to
+303
|
|
||
| - name: software.amazon.awssdk | ||
| level: WARN | ||
|
|
||
| - name: io.netty | ||
| level: WARN |
Contributor
Author
There was a problem hiding this comment.
Avoid overfilling logs with S3 debug logs
giuseppelillo
commented
Apr 27, 2026
Comment on lines
+103
to
+111
| def supports_command_config(self): | ||
| return self >= V_4_2_0 | ||
|
|
||
| def supports_formatter_property(self): | ||
| return self >= V_4_2_0 | ||
|
|
||
| def supports_command_property(self): | ||
| return self >= V_4_2_0 | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Needed to run tests, align with upstream: https://github.com/apache/kafka/blob/trunk/tests/kafkatest/version.py
1c2c2aa to
9027a20
Compare
9027a20 to
5de7cf2
Compare
EelisK
reviewed
May 7, 2026
LocalTieredStorage lives in storage/src/test/java and is needed on the broker classpath by InklessTopicMigrationTest's tiered-to-diskless migration test. Wire `testJar` into `:storage`'s `systemTestLibs` so `./gradlew systemTestLibs` produces kafka-storage-*-test.jar.
5de7cf2 to
ee8517b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.