fix(inkless): Stop replicating after migration to diskless is completed#585
Merged
giuseppelillo merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
278d971 to
a4fc758
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts inkless/diskless replication behavior so that followers stop replicating once classic→diskless migration is complete, and followers never receive diskless records past the migration seal offset.
Changes:
- Return an empty fetch response (with HW clamped to
classicToDisklessStartOffset) for follower fetches at/above the seal offset to prevent diskless replication into follower local logs. - Evict partitions from
ReplicaFetcherThreadonce the follower’s local LEO has caught up toclassicToDisklessStartOffset. - Add unit tests covering follower fetch behavior at/above/below
classicToDisklessStartOffset.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| core/src/main/scala/kafka/server/ReplicaManager.scala | Adds follower-specific handling to prevent returning diskless records after migration seal offset. |
| core/src/main/scala/kafka/server/ReplicaFetcherThread.scala | Tracks and evicts partitions from fetchers once classic→diskless migration catch-up is complete. |
| core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala | Adds tests ensuring follower fetches at/above the seal offset return empty responses and do not touch diskless/local log paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a4fc758 to
aa7a144
Compare
Stop ReplicaFetcher once diskless migration is completed. Fetch responses for followers never contain diskless offsets.
aa7a144 to
2c6181c
Compare
jeqo
approved these changes
Apr 28, 2026
viktorsomogyi
approved these changes
Apr 28, 2026
giuseppelillo
added a commit
that referenced
this pull request
May 6, 2026
…ed (#585) Stop ReplicaFetcher once diskless migration is completed. Fetch responses for followers never contain diskless offsets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diskless offsets should never be replicated to followers. Avoid this in two ways:
classicToDisklessStartOffset.