This repository was archived by the owner on Mar 3, 2025. It is now read-only.
Conversation
directory itself. Now can be installed via pip.
- Adding some documentation (docstrings) - Converting random print statements into log messages using the logger modules. - Also moved the LICENSE to the proper place in the directory hierarchy so that it shows up on github.
locations. - Spec2017Bench now overrides the SPEC17_ROOT variable in the makefile, allowing spec to now build properly. - Added a bit more documentation.
- It wasn't actually an issue with the signal handler like I thought. It was actually that I wasn't catching a GDB error from parsing the "show language" command. It is now fixed. - Some other minor tweaks.
Before we can merge 0.6, we need to do the following things: - Get single simulate and parallel simulate working again (currently I need to test after rebuilding gem5). - Get keyframes fully implemented, which will dramatically increase usability.
- Parallel still terminates early for some reason
- Need to clean up the stdout/stderr interweaving. - Should also clean up some of the logging infra
Tips and tricks: - stdout/stderr should be in text mode (at least for python2.7, I think) - need to seek to 0 to print - can't use io.StringIO because python expects fileno() to be implemented on stdout/stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of small bug fixes, and a little refactoring.
The next milestone is keyframes, so we don't take up so much disk space.