This repository was archived by the owner on Sep 21, 2022. It is now read-only.
windowSize is needed because by default it is too small#184
Closed
varya wants to merge 1 commit intogemini-testing:masterfrom
Closed
windowSize is needed because by default it is too small#184varya wants to merge 1 commit intogemini-testing:masterfrom
varya wants to merge 1 commit intogemini-testing:masterfrom
Conversation
Author
|
@SevInf ping :-) |
Contributor
|
@varya I don't think |
Contributor
|
Maybe, we need a separate document with common problems & solutions. |
Author
|
It is indeed a good idea to have "common problems" page. But if the problem is so common that all the users face it, this must be a signal to fix the problem. |
Contributor
|
@varya rebase please. I think we can just merge it |
Contributor
|
@varya ping? |
1 similar comment
Contributor
|
@varya ping? |
Author
|
Rebased |
Contributor
|
Setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windowSizeis needed to be in a default config because without it the screenshots are taken in too small size, which might be confusing.See: https://ru.bem.info/forum/502/