Skip to content

[OID4VCI] Small inconsistencies in some events#47204

Merged
mposolda merged 1 commit intokeycloak:mainfrom
mposolda:47023-oid4vci-events
Mar 18, 2026
Merged

[OID4VCI] Small inconsistencies in some events#47204
mposolda merged 1 commit intokeycloak:mainfrom
mposolda:47023-oid4vci-events

Conversation

@mposolda
Copy link
Copy Markdown
Contributor

@mposolda mposolda commented Mar 17, 2026 •
edited
Loading

closes #47203

@mposolda mposolda requested review from a team as code owners March 17, 2026 08:43
@mposolda mposolda self-assigned this Mar 17, 2026
@mposolda mposolda force-pushed the 47023-oid4vci-events branch from 15e640d to dc0c457 Compare March 17, 2026 08:48
@mposolda
[OID4VCI] Small inconsistencies in some events
fa327f4 
closes keycloak#47203

Signed-off-by: mposolda <mposolda@gmail.com>
@mposolda mposolda force-pushed the 47023-oid4vci-events branch from dc0c457 to fa327f4 Compare March 18, 2026 12:24
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown

@keycloak-github-bot keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

keycloak-github-bot Bot commented Mar 18, 2026

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.passwordless.PasskeysOrganizationAuthenticationTest#webauthnLoginWithDiscoverableKeyRequiresMembership

Keycloak CI - WebAuthn IT

java.lang.AssertionError: Expected ErrorPage but was localhost (https://localhost:8543/auth/realms/test/login-actions/authenticate?session_code=QKNcNjPO9dNL3VmAajg97r415OXplOvk3vpkSxpuTN4&execution=20e724c6-cd5d-41a6-98ba-43ad066029fd&client_id=test-app&tab_id=OEEYOd4DIOI&client_data=eyJydSI6Imh0dHBzOi8vbG9jYWxob3N0Ojg1NDMvYXV0aC9yZWFsbXMvbWFzdGVyL2FwcC9hdXRoIiwicnQiOiJjb2RlIn0)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:39)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
...

Report flaky test

graziang
graziang approved these changes Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@graziang graziang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mposolda thanks!

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown

@keycloak-github-bot keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

keycloak-github-bot Bot commented Mar 18, 2026

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.passwordless.PasskeysOrganizationAuthenticationTest#webauthnLoginWithDiscoverableKeyRequiresMembership

Keycloak CI - WebAuthn IT

java.lang.AssertionError: Expected ErrorPage but was localhost (https://localhost:8543/auth/realms/test/login-actions/authenticate?session_code=QKNcNjPO9dNL3VmAajg97r415OXplOvk3vpkSxpuTN4&execution=20e724c6-cd5d-41a6-98ba-43ad066029fd&client_id=test-app&tab_id=OEEYOd4DIOI&client_data=eyJydSI6Imh0dHBzOi8vbG9jYWxob3N0Ojg1NDMvYXV0aC9yZWFsbXMvbWFzdGVyL2FwcC9hdXRoIiwicnQiOiJjb2RlIn0)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:39)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
...

Report flaky test

@mposolda
Copy link
Copy Markdown
Contributor Author

mposolda commented Mar 18, 2026

@graziang Thanks for the review!

@mposolda mposolda merged commit 302ff9f into keycloak:main Mar 18, 2026
134 of 136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@graziang graziang graziang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mposolda mposolda

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[OID4VCI] Small inconsistencies in some events

2 participants

@mposolda @graziang