Skip to content

Start Keycloak sequentially in model tests#48523

Merged
ahus1 merged 1 commit intokeycloak:mainfrom
pruivo:t_serialize_ispn_startup
Apr 29, 2026
Merged

Start Keycloak sequentially in model tests#48523
ahus1 merged 1 commit intokeycloak:mainfrom
pruivo:t_serialize_ispn_startup

Conversation

@pruivo
Copy link
Copy Markdown
Member

@pruivo pruivo commented Apr 27, 2026 •
edited
Loading

Closes #47421
Closes #47832
Closes #47834
Closes #47833
Closes #47835
Closes #47925
Closes #47979
Closes #47990
Closes #47978
Closes #48121
Closes #48120
Closes #48230
Closes #48443
Closes #48441
Closes #48442

Issue in Infinispan under investigation

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown

@keycloak-github-bot keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

keycloak-github-bot Bot commented Apr 27, 2026

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.authz.PolicyEvaluationTest#

Keycloak CI - Base IT (3)

org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...

org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...

org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...

Report flaky test

@pruivo pruivo force-pushed the t_serialize_ispn_startup branch from 6ce036f to edac17a Compare April 28, 2026 07:26
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Apr 28, 2026
Closed
@pruivo pruivo force-pushed the t_serialize_ispn_startup branch 5 times, most recently from 7033c3d to 47ad4d4 Compare April 29, 2026 17:34
@pruivo pruivo changed the title Serialize ISPN startup Start Keycloak sequentially in model tests Apr 29, 2026
@pruivo
Start Keycloak sequentially in model tests
0a05588 
Closes keycloak#47421
Closes keycloak#47832
Closes keycloak#47834
Closes keycloak#47833
Closes keycloak#47835
Closes keycloak#47925
Closes keycloak#47979
Closes keycloak#47990
Closes keycloak#47978
Closes keycloak#48121
Closes keycloak#48120
Closes keycloak#48230
Closes keycloak#48443
Closes keycloak#48441
Closes keycloak#48442

Signed-off-by: Pedro Ruivo <1492066+pruivo@users.noreply.github.com>
@pruivo pruivo force-pushed the t_serialize_ispn_startup branch from 47ad4d4 to 0a05588 Compare April 29, 2026 17:36
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Apr 29, 2026
Closed
@ahus1 ahus1 marked this pull request as ready for review April 29, 2026 20:01
@ahus1 ahus1 requested review from a team as code owners April 29, 2026 20:01
@ahus1 ahus1 merged commit 228550b into keycloak:main Apr 29, 2026
86 checks passed
@ahus1
Copy link
Copy Markdown
Member

ahus1 commented Apr 29, 2026

@pruivo - thank you for the change. Would you expect that this is also happening in 26.6? If yes, would that be a candidate to backport, or would you rather wait while you analyze this in more detail?

@pruivo pruivo deleted the t_serialize_ispn_startup branch April 29, 2026 20:17
@pruivo
Copy link
Copy Markdown
Member Author

pruivo commented Apr 29, 2026

@ahus1 It is better to backport if you don't mind.

@ahus1
Copy link
Copy Markdown
Member

ahus1 commented Apr 29, 2026

OK, then let's do a backport. I'll do that tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test: org.keycloak.testsuite.model.session.UserSessionProviderOfflineModelTest#testOfflineSessionLazyLoadingPropagationBetweenNodes Flaky test: org.keycloak.testsuite.model.session.UserSessionPersisterProviderTest#testExpirationDistribution Flaky test: org.keycloak.testsuite.model.session.UserSessionPersisterProviderTest#testUserRemoved Flaky test: org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest#testPersistenceClientSessionsMultipleNodes Flaky test: org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest#testPersistenceMultipleNodesClientSessionAtSameNode
Flaky test: org.keycloak.testsuite.model.session.AuthenticationSessionTest#testConcurrentAuthenticationSessionsRemoval Flaky test: org.keycloak.testsuite.model.session.UserSessionInitializerTest#testUserSessionPropagationBetweenSites Flaky test: org.keycloak.testsuite.model.session.UserSessionProviderOfflineModelTest#testOfflineSessionLazyLoading Flaky test: org.keycloak.testsuite.model.session.AuthenticationSessionTest#testConcurrentAuthenticationSessionsCreation Flaky test: org.keycloak.testsuite.model.session.UserSessionProviderModelTest#testCreateUserSessionsParallel

2 participants

@pruivo @ahus1