fix: temp directory refinements#48608
Open
shawkins wants to merge 1 commit intokeycloak:mainfrom
Open
Conversation
2 tasks
closes: keycloak#48566 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors temporary-directory handling so it is initialized during application startup instead of construction/build-time, and aligns the temp path with each application's data directory setup.
Changes:
- Moves
kc.io.tmpdirinitialization fromKeycloakApplicationconstruction intostartup(). - Updates Quarkus and RESTEasy test applications to source temp/data paths from their data-directory configuration.
- Improves gzip cache directory warning output and adjusts testsuite data-dir bootstrapping.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
testsuite/utils/src/main/java/org/keycloak/testsuite/KeycloakServer.java |
Changes how the embedded testsuite server derives its data directory. |
services/src/test/java/org/keycloak/services/resteasy/ResteasyKeycloakApplication.java |
Switches the RESTEasy test app to use jboss.server.data.dir as its data dir. |
services/src/main/java/org/keycloak/services/resources/KeycloakApplication.java |
Moves temp-dir initialization to startup and removes the fallback in getTmpDirectory(). |
services/src/main/java/org/keycloak/encoding/GzipResourceEncodingProviderFactory.java |
Tweaks gzip cache directory creation and warning logging. |
quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/integration/jaxrs/QuarkusKeycloakApplication.java |
Changes Quarkus data-dir fallback behavior when kc.home.dir is missing. |
Contributor
Author
|
Let's wait for #48733 to go in first (which will fix this on main), then reasses the refinements here. |
Contributor
|
Adding hold label to wait for #48733. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #48566