Fix critical bugs in OID4VC and FAPI security code#48678
Closed
deepshekhardas wants to merge 15 commits intokeycloak:mainfrom
Closed
Fix critical bugs in OID4VC and FAPI security code#48678deepshekhardas wants to merge 15 commits intokeycloak:mainfrom
deepshekhardas wants to merge 15 commits intokeycloak:mainfrom
Conversation
- Fix SdJwtCredentialBuilder: entry.getValue() instanceof List instead of entry instanceof List - Fix SecureRequestObjectExecutor: Use currentTimeMillis()/1000 for proper long timestamp comparison (Y2K38 bug) - Fix SecureCibaSignedAuthenticationRequestExecutor: Use currentTimeMillis()/1000 for proper long timestamp comparison Resolves TODO/FIXME comments from top contributors' work
added 2 commits
May 4, 2026 18:15
- Add comprehensive javadoc to validateAndCastConfiguration method - Update UserConsentManager javadoc to explain boolean vs Boolean return type - Remove obsolete TODO comment from DefaultClientTypeProvider
added 6 commits
May 5, 2026 17:56
Cherry-picked from upstream: 5811348 Implements the AuthZen Evaluations API endpoint for batch authorization decisions. This is part of the AuthZen authorization standard. Changes: - Added EvaluationsRequest and EvaluationsResponse models - Implemented new /access/v1/evaluations endpoint - Added support for evaluation semantics: - execute_all: Execute all evaluations - deny_on_first_deny: Stop on first deny - permit_on_first_permit: Stop on first permit - Added test client helpers and test cases Closes: keycloak#47825
Cherry-picked from upstream: f66ae8a Implements CRUD operations for Verifiable Credentials in OID4VCI protocol. Changes: - Added UserVerifiableCredentialEntity for database storage - Added UserVerifiableCredentialModel for data model - Added UserVerifiableCredentialRepresentation for API - Created Admin REST endpoints: - POST /users/{id}/verifiable-credentials - GET /users/{id}/verifiable-credentials - DELETE /users/{id}/verifiable-credentials/{credentialId} - Added JPA changelog for database schema - Added test cases for CRUD operations Closes: keycloak#48546
Cherry-picked from upstream: 53f0251 Adds a startup validation check to verify that all required database indexes exist. This helps prevent performance issues and identifies missing indexes early. Changes: - Added DatabaseIndexChecker class for startup validation - Checks for critical indexes like: - IDX_IDP_FOR_LOGIN (for identity provider login) - Other performance-critical indexes - Added test cases to verify the checker works correctly - Helps with database migration validation This is important for production deployments to ensure optimal database performance.
Feat: AuthZen Evaluations API - Add multi-evaluation endpoint
Feat: OID4VCI Credentials CRUD - Database and Admin REST endpoints
Feat: Add startup check for missing database indexes
Member
|
Please consult CONTIBUTING.md before contributing. Also, you already have to PRs open which is the maximum for new contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes critical bugs, improves logging, and enhances code quality:
Bug Fixes:
Logging Improvements:
Documentation Improvements:
Impact: