Do not allow wildcards in the hostname for Valid Redirect Address#48793
Open
rmartinc wants to merge 1 commit intokeycloak:mainfrom
Open
Do not allow wildcards in the hostname for Valid Redirect Address#48793rmartinc wants to merge 1 commit intokeycloak:mainfrom
rmartinc wants to merge 1 commit intokeycloak:mainfrom
Conversation
Closes keycloak#48430 Signed-off-by: rmartinc <rmartinc@redhat.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48430
This PR avoid wildcards in the hostname. For backwards compatibility it manages
https://test*ashttps://test/*. Maybe it's a bit confusing, so if you prefer to not modify the configured valid redirect URI and just reject (performing exact matching) for those kind of patterns just let me know. I have been hesitating between the two options all the time.