Link authentication flow UsedBy clients to client settings#48841
Open
singhvishalkr wants to merge 1 commit intokeycloak:mainfrom
Open
Link authentication flow UsedBy clients to client settings#48841singhvishalkr wants to merge 1 commit intokeycloak:mainfrom
singhvishalkr wants to merge 1 commit intokeycloak:mainfrom
Conversation
…ings Signed-off-by: Vishal Kumar Singh <vishal.kr.singh2021@gmail.com>
95a32b1 to
2cd8e8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40211.
The flows API already returns each overriding client's \clientId\ string (\AuthenticationMapper\ uses \ClientModel#getClientId). The admin routes expect the internal client id in the URL (\ClientsSection\ links with \client.id), so this resolves each label via \�dminClient.clients.find({ clientId }), matches the exact \clientId, and wraps the label in \ oClient\ for both the popover (≤8 clients) and the paginated modal.