Conversation
In capture mode, onKeypress was checked before named bindings. Keys like backspace have input='' so onKeypress silently did nothing and returned early, making the explicit binding unreachable. Swap the dispatch order: named bindings always fire first; onKeypress is now a fallback for keys with no explicit handler. passthrough retains its original meaning — keys that should bubble to parent scopes.
Reflect the corrected dispatch order: named bindings fire before onKeypress, and passthrough means bubble-to-parent rather than bypass-capture-to-reach-bindings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.