fix(command-palette): make useKeybindingRegistry reactive#54
Merged
Conversation
Add version counter to FocusStore and subscribe via useSyncExternalStore so HintsBar updates on focus/node changes. Deduplicate available bindings by key to prevent duplicates from ancestor scopes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FocusStorewithgetVersion()method, incremented innotify()useKeybindingRegistryto store mutations viauseSyncExternalStoresoHintsBarre-renders on focus/node changesavailablebindings by key (innermost binding wins), preventing duplicate hints from ancestor scopesTest plan
npx tsc --noEmitpassespnpm play playground/examples/nested-boxes.tsx— HintsBar updates as you navigate (h/l) and drill in/out (enter/esc), no duplicate entriespnpm play playground/examples/command-palette.tsx— existing CommandPalette behavior unchanged